Use gopkg.in/Masterminds/squirrel.v1 instead of github.com/Masterminds/squirrel

[faide]

because the github version pulls from master and is not in synch with what kallax uses from squirrel.

See #279 for more reference

[nadiamoe]

Which go version are you using? According to squirrel's README:

NOTE: as of Go 1.6, go get correctly clones the Github default branch (which is v1 in this repo). import "github.com/Masterminds/squirrel"

PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem.

[faide]

I am using go 1.10.3

Le 1 juil. 2018 2:30 PM, "Roberto Santalla" [email protected] a écrit :

Which go version are you using? According to squirrel's README:

NOTE: as of Go 1.6, go get correctly clones the Github default branch (which is v1 in this repo). import "github.com/Masterminds/squirrel"

PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/src-d/go-kallax/pull/280#issuecomment-401603684, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeL8aHbU1ttiPeSEw60-0czCNjJT8gdks5uCMDfgaJpZM4U7bGM .

[WnP]

I'm using go version go1.11.1 linux/amd64 and have the same issue, this PR fix it. Thanks @faide