gitbase-web icon indicating copy to clipboard operation
gitbase-web copied to clipboard

Forbid "console" funcs

Open dpordomingo opened this issue 7 years ago • 4 comments

from https://github.com/src-d/gitbase-playground/pull/16#discussion_r187585501

It could be a good idea

dpordomingo avatar May 16 '18 06:05 dpordomingo

console is forbidden already (as a warning): https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/errors.js#L23

smacker avatar May 16 '18 09:05 smacker

but ci does not fail with warnings, does it?

dpordomingo avatar May 18 '18 17:05 dpordomingo

nope. And this allows PR like this: https://github.com/src-d/gitbase-playground/pull/35/files#diff-48bb2e3e3e5708d8083b1cff1fff3949R81 which isn't bad at this stage of the project. :)

smacker avatar May 18 '18 17:05 smacker

The point of this issue is to address this matter whenever we're ready to do so

dpordomingo avatar May 18 '18 23:05 dpordomingo