gitbase-web
gitbase-web copied to clipboard
Forbid "console" funcs
from https://github.com/src-d/gitbase-playground/pull/16#discussion_r187585501
It could be a good idea
- [ ] to forbid
consolecommands (.eslintrc.js::rules['no-console']), and - [ ] to provide a logger wrapper as in
CAT?
console is forbidden already (as a warning): https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/errors.js#L23
but ci does not fail with warnings, does it?
nope. And this allows PR like this: https://github.com/src-d/gitbase-playground/pull/35/files#diff-48bb2e3e3e5708d8083b1cff1fff3949R81 which isn't bad at this stage of the project. :)
The point of this issue is to address this matter whenever we're ready to do so