gemini icon indicating copy to clipboard operation
gemini copied to clipboard

Add Scala linter to CI

Open bzz opened this issue 7 years ago • 4 comments

TODO:

  • [x] add/document sbt task with linter and code style
  • [x] integrate linter in CI

As well noted in https://github.com/src-d/gemini/pull/48#pullrequestreview-101487845

I would be nice if all of us use the same configuration for code style.

bzz avatar Mar 06 '18 10:03 bzz

It looks like we already have sbt scalastyle in place. As can be seen in travis.yml, and travis logs.

I'll wait for you to close the issue, just in case I misunderstood it and there's something else missing.

carlosms avatar Mar 15 '18 18:03 carlosms

Is it possible to catch such things:

  • https://github.com/src-d/gemini/pull/48/files#diff-7d8cae56157bb5c2c2053b9797014e8f
  • https://github.com/src-d/gemini/pull/48/files#diff-768357618a8db6a4da444273c800e8d9
  • https://github.com/src-d/gemini/pull/48/files#diff-747eed6d907b7380e439aec919e624c6R169

by linter/codestyle?

smacker avatar Mar 15 '18 21:03 smacker

Those are basically default InteliJ scala styles. 👍 for importing them to our scalastyle profile, so CI could verify.

@carlosms please feel free to ~update pr description~ with your finds/changes in scope.

bzz avatar Mar 16 '18 10:03 bzz

Addressed by #86 now

bzz avatar Apr 17 '18 22:04 bzz