Use `icmd` to test interactive SQL REPL

Open se7entyse7en opened this issue 6 years ago • 2 comments

Current the test of interactive SQL REPL doesn't use icmd, but it uses os/exec directly.

Context here.

Apr 05 '19 17:04 se7entyse7en

I don't see any problem with testing repl without icmd. This test is clearly different from others and I'm not sure such use case will be ever supported by icmd project.

Apr 05 '19 18:04 smacker

This test is clearly different from others

True, I just think that in case we're able to use icmd even in this case we have more consistency as we would have a single api for running commands. I haven't tried patching it locally, but it should be easy to try it and eventually open a PR to icmd.

Apr 05 '19 18:04 se7entyse7en