Errors and empty responses must be handled correctly on FE

[smacker]

right now it's not always true.

• [x] Check tests, make sure it covers error path. Add expected result. Fix code if test doesn't pass. #205
• [ ] Check tests, make sure it covers empty path. Add expected result. Fix code if test doesn't pass.
• [ ] Mock responses 1 by 1 and make sure UX is good for each such response. Fix code if UX is not good.

[dpordomingo]

I saw some of them... but it would be great to have a list...

[smacker]

yes. It's part of this issue. Find those places. I would go like this:

1. Check tests, make sure it covers error path. Add expected result. Fix code if test doesn't pass.
2. Check tests, make sure it covers empty path. Add expected result. Fix code if test doesn't pass.
3. Mock responses 1 by 1 and make sure UX is good for each such response. Fix code if UX is not good.

[ricardobaeta]

I'm here to help.

[dpordomingo]

@smacker I moved this to in progress because I saw there is a PR addressing some improvement required by this issue.

next steps:

• if there is no pending work to do about this issue → you can close it :tada:
• if there is pending work to do:
  • and you're already on it → keep it as in progress,
  • but you're not on it → move it to TODO

Many thanks!!