Resume-Matcher icon indicating copy to clipboard operation
Resume-Matcher copied to clipboard

fix: issue with [docker-compose up] command

Open rizahmeds opened this issue 2 years ago • 13 comments
trafficstars

Pull Request Title

Fixed issue, while running command docker-compose up locally.

Related Issue

Fixes #144

Description

Type

  • [x] Bug Fix
  • [ ] Feature Enhancement
  • [ ] Documentation Update
  • [ ] Code Refactoring
  • [ ] Other (please specify):

Proposed Changes

  • Change python base-image from python:3.11.0-slim to python:3.11-slim-bullseye
  • Remove unnecessary RUNs

Screenshots / Code Snippets (if applicable)

Screenshot 2023-09-13 at 18 49 52

How to Test

  1. docker-compose up

Checklist

  • [x] The code compiles successfully without any errors or warnings
  • [x] The changes have been tested and verified
  • [ ] The documentation has been updated (if applicable)
  • [ ] The changes follow the project's coding guidelines and best practices
  • [x] The commit messages are descriptive and follow the project's guidelines
  • [ ] All tests (if applicable) pass successfully
  • [x] This pull request has been linked to the related issue (if applicable)

Additional Information

rizahmeds avatar Sep 13 '23 13:09 rizahmeds

Hi @rizahmeds I'll take a look at it. Thanks for the PR.

srbhr avatar Sep 14 '23 07:09 srbhr

Hi @rizahmeds I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

srbhr avatar Sep 21 '23 21:09 srbhr

Hi @rizahmeds I'm unable to get this running properly in my local. I'll ask in the discord for anyone to test it out.

Alright @srbhr Thanks!

rizahmeds avatar Sep 22 '23 05:09 rizahmeds

hi @rizahmeds , I was getting the below error when i test your code image I think it is an issue with the python version. can you test from your end and verify if it working? are you able to get the similarity score when you are using the config file?

SubramanyamChalla24 avatar Sep 26 '23 08:09 SubramanyamChalla24

Hi @SubramanyamChalla24, Thanks for pointing this out. This error is due to older version of QdrantClient which didn't had url parameter. Make sure you have qdrant-client>=1.2 in virtualenv or docker container. (Note: Please do pip list to check qdrant-client version installed)

@srbhr Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

Screenshot 2023-09-27 at 22 29 08

rizahmeds avatar Sep 27 '23 17:09 rizahmeds

Now i am just wondering, why config.yml have been remove from scripts/similarity path, because we still reading the config file here in this line of code

That is because the user needs to add the config file manually as it contains the private api keys.

SubramanyamChalla24 avatar Sep 27 '23 17:09 SubramanyamChalla24

@SubramanyamChalla24 Make sense. Earlier we only needed to replace the values that's why I got confused 😅

rizahmeds avatar Sep 27 '23 17:09 rizahmeds

This error is due to older version of QdrantClient which didn't had url parameter. Make sure you have qdrant-client>=1.2 in virtualenv or docker container. (Note: Please do pip list to check qdrant-client version installed)

I have the latest version. It's not an error with the version though. can you check from your side including the config file?

SubramanyamChalla24 avatar Sep 27 '23 17:09 SubramanyamChalla24

Yes, i already checked with the config.yaml file. Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

rizahmeds avatar Sep 27 '23 17:09 rizahmeds

Cohere doesn't require a credit card. Can you check it once?It required a card before but it doesn't need it now.

Yes, i already checked with the config.yaml file. Since I do not have the cohere API key(Because it requires me to add a credit card detail, which I don't have 🥺), it raises another exception for me. So I can't completely test it.

SubramanyamChalla24 avatar Sep 27 '23 18:09 SubramanyamChalla24

Thanks for the update @SubramanyamChalla24. Yes i have got the Cohere Trial key. Then i reinitialized qdrant cluster which was suspended. Here you go, Finished getting similarity score.

Screenshot 2023-09-28 at 00 31 26

rizahmeds avatar Sep 27 '23 19:09 rizahmeds

Great work in collaboration @rizahmeds and @SubramanyamChalla24 🔥 I like the teamwork here. So, is this PR working now?

srbhr avatar Sep 28 '23 11:09 srbhr

So, is this PR working now?

I couldn't replicate it. It still shows the same error though. Probably someone has to try and verify it.

SubramanyamChalla24 avatar Sep 28 '23 17:09 SubramanyamChalla24