awscosts icon indicating copy to clipboard operation
awscosts copied to clipboard

Dependence on oj means JRuby needs to have C extensions enabled

Open lardcanoe opened this issue 8 years ago • 1 comments

In https://github.com/srbartlett/awscosts/commit/82ce80d9e8e0e08a43bb9cd40e241fa544463a24 you switched to using oj, which means when this gem is used in JRuby it requires C extensions to be enabled.

Was there any specific reason for oj? I suspect it is slightly faster than JSON...?

lardcanoe avatar Mar 19 '16 01:03 lardcanoe

Hi,

The 'oj' gem was introduced by a commit in a pull request so I can't answer your question directly but from looking at the code I see no reason is use it.

Happy to accept a PR should you wish to remove 'oj'

srbartlett avatar Mar 29 '16 05:03 srbartlett