spark-MDLP-discretization icon indicating copy to clipboard operation
spark-MDLP-discretization copied to clipboard

Published 20 hours ago • verified publisher icon sramirez

Add jenkinsfile to enable CI building in jenkins

Open barrybecker4 opened this issue 7 years ago • 3 comments

I would like to investigate creating a PR to add a jenkins file to allow for automated building if there is a jenkins server. The jenkins file will have no effect if there is no jenkins server.

barrybecker4 avatar Jan 23 '18 14:01 barrybecker4

Sounds good. If this change won't affect non-jenkin server, go ahead.

sramirez avatar Jan 24 '18 09:01 sramirez

@sramirez, I added the Jenkinsfile on our fork, but I'm not going to do a PR for it because it is fairly specific to our use. It does not effect any non-jenkins server. One question I have is, why do we need the pom.xml file checked in. It duplicates the version numbers that are already in sbt - so some of them are bound to get out of sync. When I deploy to a JFrog artifactory all the pom file is automatically generated. I think it should be removed from git to avoid confusion. Do you agree?

barrybecker4 avatar Apr 25 '18 16:04 barrybecker4

@barrybecker4 Maybe I'm wrong, I'm not an expert in this matter. But some people don't use sbt, but maven (including me). I usually compile and package my project with maven, so maybe we can add a message to the README file giving some indications about what you said above. What do you think?

sramirez avatar Apr 26 '18 08:04 sramirez