Sam Rabiyah

Results 43 issues of Sam Rabiyah

In test_nycdb.py, there are some simple tests for other "derived" tables like in the `test_hpd_registrations_derived_tables` function. We should consider adding one or a few simple tests for the `oca_case_summary` table...

Looks like #158 added test data but forgot to add an actual Python test...

All of the values in that field show up as null... maybe there is a bug in a date format transformation somewhere?

I noticed that `https://whoownswhat.justfix.nyc/en/bbl/3005380001` brings up a page for "BARUCH" Public Housing Development in Manhattan even though the BBL is for Manhattan. Note that this issue was present _before_ merging...

We currently have two `SplitBBL` functions that serve the same purpose— one in our helpers.ts file and one that is used in our GeoSearch address search, as identified #332.

Let's test that API data matches the new type definitions in #294.

Our current implementation of `getIndicatorHistory` in the APIClient uses a typecast to avoid issues with matching types. This should ideally be changed to a valid type definition.

Let's see if there are any errors we can just fix to reduce clutter. Let's also explore RollBar "classification" systems that can group multiple errors together to reduce how many...

We noticed this warning in the browser after merging #364. Update: this might actually be a bug w/ xstate that was just fixed? See https://github.com/davidkpiano/xstate/issues/1132#issuecomment-663869567.

In our DetailView component we use the `document.querySelector()` function to scroll to the top of the wrapper div. This usage created some problems when we converted to typescript as we...