GLITCH icon indicating copy to clipboard operation
GLITCH copied to clipboard

Swarm and Nomad support

Open sfondev opened this issue 9 months ago • 2 comments

PR that will contain all the changes for supporting Docker Swarm and HashiCorp Nomad

sfondev avatar Apr 10 '25 22:04 sfondev

I added some comments but what concerns be the most is the lack of added tests. Do you have tests for the parsers and for the new smells?

When I was coding the parsers I was mostly testing with example files from the web I found to be more or less "complex" and that had the attributes needed to do the detection. I tested by running the parser on them until parsing all the information needed and they didn't error out. Indeed unfortunately the parsers aren't robust for real world usage, since when running GLITCH on the whole datasets they do end up error out on some of the files. However, in that case some of the errors are really not the parsers fault, since they happen due to files that aren't really valid Compose/Swarm files or Nomad. But creating or choosing test files, for the smells should be doable.

sfondev avatar Aug 25 '25 15:08 sfondev

It is OK if some the parsers are not able to parse some files. The same happens for the other technologies

Nfsaavedra avatar Aug 25 '25 19:08 Nfsaavedra