PHP_CodeSniffer icon indicating copy to clipboard operation
PHP_CodeSniffer copied to clipboard

Add MixedBooleanOperatorSniff

Open TimWolla opened this issue 4 years ago • 4 comments
trafficstars

Hi :wave:

This is my first contribution to PHP CodeSniffer. This PR adds a sniff that detects mixed boolean operators (&&, ||) within a single expression without making precedence clear using parentheses.

I hope I did not miss an existing sniff that already does what I want this sniff to do. Please also let me know if I violated any written or unwritten rules regarding the namespace structure, code formatting, commit messages, etc or if you think I missed some edge case within my unit test.

TimWolla avatar Feb 02 '21 15:02 TimWolla

I was going through the list of my open PRs:

I'm seeing that this PR was assigned to a project / to the idea bank. How will this process further? I don't plan on making any more changes, unless you see issues during review.

TimWolla avatar Aug 27 '21 10:08 TimWolla

Sorry this hasn't moved. I've been prioritising bug fixes and support for newer PHP versions so I haven't looked into this yet.

gsherwood avatar Aug 30 '21 07:08 gsherwood

Understood, thank you for the update.

TimWolla avatar Aug 30 '21 07:08 TimWolla

Hi! It's been another 6 months. I've just rebased my branch on the latest master.

Do you have some cycles to take a look at this?

TimWolla avatar Mar 01 '22 14:03 TimWolla