false positives, reporting on the HTML_CodeSniffer UI

[waffledonkey]

I see errors and warnings related to the HTML_CodeSniffer UI itself; mostly duplicate ID errors

Duplicate id attribute value "Icons-/-Controls-/-Subtract---minimize" found on the web page.

<path d="M34,18 C34,18.5522847 ...

[ironikart]

Hi @waffledonkey, are you able to provide more information to replicate the issue where HTMLCS is showing errors from its own UI? The errors themselves do need to be fixed, but the auditor ignores results from its own generated DOM.

[waffledonkey]

Maybe?

On Chrome for Mac.

Enable always show Bookmarks bar and then drag bookmarklet to bar.
Go to a website, I opted for att.com Click the bookmarklet.
Click View Report On the first page are two "Duplicate id attribute" errors for "icons-/-Controls-/..." Expand one

The message correctly says: "Unable to point to the element associated with this issue. Unable to point to this element because it is located outside of the document's body element."

…so that's good, but if we know it's outside of the document's body element, why is it showing up in the report? It seems like it would make more sense to exclude such issues from the report versus explain why they can't be pointed to OR maybe if there was a a preference type setting that offered both? It just seems odd that a tool used to identify accessibility issues, has accessibility issues. It strains credibility — and confidence.

Thank you for your time and consideration (and the tool, which I've been recommending for years)

On Oct 27, 2019, at 4:34 PM, Anthony Barnes [email protected] wrote:

Hi @waffledonkey https://github.com/waffledonkey, are you able to provide more information to replicate the issue where HTMLCS is showing errors from its own UI? The errors themselves do need to be fixed, but the auditor ignores results from its own generated DOM.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/squizlabs/HTML_CodeSniffer/issues/268?email_source=notifications&email_token=ADAP7HVQC5YJJHCLY5CD6QDQQYQPDA5CNFSM4JFMOZO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECLLCWQ#issuecomment-546746714, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAP7HT7GSXNMMNVQ53KPYLQQYQPDANCNFSM4JFMOZOQ.

[ironikart]

Thanks, I can replicate the issue you see on that particular site. I haven't seen this occur before so my initial thought it some conflicting JS, I will debug further.

[ironikart]

I had initially thought the errors you posted were from the HTMLCS Auditor UI, but it appears they are coming from the source of the page. One issue is that the page fails quite badly in the W3C HTML validator. There may be a separate HTMLCS issue here where embedded SVGs cannot be located in the DOM.