solax icon indicating copy to clipboard operation
solax copied to clipboard

raise validation error for all zero response data

Open Darsstar opened this issue 2 years ago • 3 comments

Succeeds #142, thanks @VadimKraus.

Darsstar avatar Apr 02 '24 13:04 Darsstar

how about we just reopen #142 :D

VadimKraus avatar Apr 02 '24 18:04 VadimKraus

how about we just reopen #142 :D

I can't. Feel free to rebase your branch on master yourself.

Darsstar avatar Apr 02 '24 18:04 Darsstar

Ah sorry, there were conflicts again? nvm then :P

VadimKraus avatar Apr 03 '24 06:04 VadimKraus

@Darsstar, could you please confirm if this change was already merged/deployed? sorry, because I'm already a bit confused...

joseal avatar May 16 '24 11:05 joseal

For all intents and purposes: no, it has not.

Darsstar avatar May 16 '24 11:05 Darsstar

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

squishykid avatar Jun 05 '24 11:06 squishykid

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

I went ahead and created https://github.com/home-assistant/core/pull/118888

Darsstar avatar Jun 05 '24 14:06 Darsstar