squirrelly icon indicating copy to clipboard operation
squirrelly copied to clipboard

fix filter signature to allow params, issue in test

Open ilanl opened this issue 4 years ago • 3 comments

@nebrelbug I have an issue with the test I'm adding. I was expecting to use a filter that receive an array and as obj and returns a promised string based on parameters. Parameters are received correctly but the obj sent is string instead of array type. What am I missing?

ilanl avatar Aug 09 '20 08:08 ilanl

@ilanl this looks perfect!

The problem in the test is that Squirrelly automatically auto-escapes references before passing them through filters (#189). This has the side effect of converting them to strings.

Since this is a fairly common use case, I'm going to do what I discussed in #189 and make the XML-escape filter (e) the last filter applied to a reference, which should solve the problem. I'll ping you once I've done that :smiley:

nebrelbug avatar Aug 15 '20 01:08 nebrelbug

Hey @ilanl, I just released version 8.0.4 which applies Squirrelly's XML-escape filter after all other filters. Once you merge my recent changes into this PR, the tests should pass perfectly.

nebrelbug avatar Aug 15 '20 02:08 nebrelbug

Hi @ilanl! Another PR was just merged which fixes the filter signature problem. However, I'd love to merge the test from your PR.

Do you mind if I remove the src/containers.ts file from the PR and then re-trigger the Travis CI build?

Thanks!

nebrelbug avatar Sep 09 '20 18:09 nebrelbug