squidowl
Add support for Windows binary meta information and fix WiX installer…
This PR add support for getting the Windows binary meta information in line with the release version and some other information. Also it updates the WiX installer description to have to correct release version also.
To achieve this i added two build dependencies:
- windows_exe_info = "0.4"
- cargo-edit = "0.12"
Tell me what you think.
Note @KaiKorla that i just modified the Wix file slightly after #363 was merged.
@KaiKorla @casperstorm I noticed we were pulling down windows deps / using them in build.rs for non windows targets. Can you both confirm that 791b6ce doesn't break the windows build?
@KaiKorla I've rebased all your commits onto main. Please use git rebase instead of git merge so we can keep a clean git history, thanks!
@KaiKorla @casperstorm I noticed we were pulling down windows deps / using them in
build.rsfor non windows targets. Can you both confirm that 791b6ce doesn't break the windows build?
Working locally. Binary and installer looking good in the Windows sandbox. IMO everything is working as expected. We should test it with the release pipeline anyway. tyvm!
As discussed on IRC, final two missings:
- Install dir should be
C:\Program Files\Halloyinstead ofC:\Program Files\Squidowl\Halloy- When opening a url scheme the Halloy icon shows description rather than just title.
- Install dir is fixed
- Regarding the url sheme and the description: It seems that Windows is showing the "File Description" metadata and then cache it somehow (i try to figure it out in the microsoft documentation). The "File Description" is currently set by "windows_exe_info::versioninfo::link_cargo_env();" in the build.rs and takes the value from the description field in the [package] section in the Cargo.toml file. IMHO we shoudln't change this.
/edit The URL association has change also with Windows 10. I'll commit & push an update for this later. Then it should work for all URL schemes (halloy://, irc://, ircs://).