mkdocs-material icon indicating copy to clipboard operation
mkdocs-material copied to clipboard

Fix issue with author images not filling container height

Open uus-dev opened this issue 1 year ago • 1 comments

Without this some author avatars became squeezed if the avatar image didn't fill the container height.

Before After
image image

uus-dev avatar Aug 21 '24 13:08 uus-dev

Thanks for the PR. Please provide a minimal reproduction. The problem with height: 100% is that it will stretch non-rectangular images. We should use height: auto here, but that's already defined for images, which will scale the image to adapt to aspect-ratio. For the author avatars, this should be a square:

https://github.com/squidfunk/mkdocs-material/blob/8ee7137e48bd59ef451b20fb14c6c86fa6132da1/src/templates/assets/stylesheets/main/_typeset.scss#L371-L377

Please provide a reproduction with exact steps how to observe the issue, because I'm not seeing it.

squidfunk avatar Aug 22 '24 09:08 squidfunk

Closing as stale.

squidfunk avatar Sep 02 '24 09:09 squidfunk