Martin Donath
Martin Donath
Note that there's no necessity in upstreaming this to Insiders – I'll handle that immediately once we merge this PR.
@kamilkrzyskow ha, you know me quite well now. Sorry, if I'm pedantic, just trying to keep everything as tidy as possible 😅 Regarding #7118 – can we solve this here...
Thanks, @alexvoss. It's actually a regression of 9.5.19, where I tried to make the social plugin work with other themes, see https://github.com/squidfunk/mkdocs-material/commit/6a761ed418f6daaeaae313971e7d653fe1599661. The new tags plugin should not suffer from...
@kamilkrzyskow You got me! 🫣 You're of course right. The code base of the tags and social plugin will be entirely replaced when the next funding goal is hit, which...
I've adapted the fix to the social plugin in Insiders (which already works for third party themes) in [`aeed812`](https://github.com/squidfunk/mkdocs-material-insiders/commit/aeed812bf08e13b5eb8e78753e5fb15e40fe923d). I hope I'm not too pedantic, but I restructured the code...
Thanks for testing, I guess we're ready to merge then. I guess it's a matter of taste what belongs where, but I think I saw @kamilkrzyskow note at some point...
@alexvoss Thanks! I don't think the mentioned upstream issue talks about the same error, it's a different error not related to Material for MkDocs but to all themes. More specifically:...
Of course not 🫣 Just upgraded the plugin and now I see the remote image errors: ``` INFO - Cleaning site directory INFO - Building documentation to directory: /Users/squidfunk/.workspace/squidfunk/repos/mkdocs-material/insiders/site WARNING:root:Remote...
We should currently not bump it. The version range we support is `>=1.6, < 2`, which is given by `~=1.6` (semver). If we bump it, we force the update upon...
Thanks for reporting. Please understand that we need a reproduction to look into it. > Because it involves comment overrides, I can't add info plugin, but I remove other overrides,...