squid icon indicating copy to clipboard operation
squid copied to clipboard

Published 20 hours ago • verified publisher icon squid-cache

Move generatingConnect flag to HttpRequest

Open yadij opened this issue 2 years ago • 1 comments

It is a flag to control ACL matching against the HttpRequest data and should not have been directly part of MasterXaction at all.

yadij avatar Mar 16 '22 14:03 yadij

It is a flag to control ACL matching against the HttpRequest data

What makes you think that? AFACIT, commit 090f1d3 reached (and painstakingly documented) essentially the opposite conclusion.

The actual current code usage of this flag. It is set to true prior to HttpStateData::httpBuildRequestHeader() and set back to false immediately after. It should really be a flag of HttpStateData object, but that object is not passed to the access control code. The HttpRequest object used by HttpStateData::httpBuildRequestHeader() is where those access controls get details from HttpStateData.

How were this PR changes tested?

  • ./test-builds.sh
  • running real-world traffic through Squid
  • Semaphoreci tests

still awaiting Jenkins results.

yadij avatar Mar 16 '22 17:03 yadij