squid icon indicating copy to clipboard operation
squid copied to clipboard

Move ClientActiveRequests feature to dedicated source files

Open kinkie opened this issue 4 years ago • 5 comments

kinkie avatar May 18 '20 07:05 kinkie

On Mon, May 18, 2020 at 10:39 PM Alex Rousskov [email protected] wrote:

@rousskov commented on this pull request.

In src/Makefile.am https://github.com/squid-cache/squid/pull/637#discussion_r426907599:

  • ClientActiveRequests.h \
  • ClientActiveRequests.cc \

Yes, that so called "good" naming convention is not so good for the purpose of listing dependencies in a consistent human-friendly way. We have to pick our poison.

Again, I know that this area is currently very messy, and I do not insist on this minor mess-reducing change.

Yes. It would be out ofd scope for this PR anyway.

-- Francesco

kinkie avatar May 18 '20 21:05 kinkie

After addressing the latest review concerns, please update PR title and description to reflect the current PR changes.

rousskov avatar May 26 '20 19:05 rousskov

Must have happened when I upgraded master to a still-supported version of LTS ubuntu :
Which I will have to do another couple of times to bring to LTS-current. I'm sorry, I hadn't noticed

-- Francesco

kinkie avatar Jun 10 '20 21:06 kinkie

@rousskov , I'm sorry but in all the long history of this PR I have lost track of what is still missing for approval. I apologise for asking you to spend more time on this, but I'm at a loss. The long history means also a lot of rebases which muds the waters.

kinkie avatar Jun 11 '20 08:06 kinkie

I think I have resolved all pending issues.

kinkie avatar May 20 '21 19:05 kinkie

Abandoning. Unentangling from the effects of PR 906 is equivalent to redoing the work

kinkie avatar Dec 25 '23 14:12 kinkie