squid
squid copied to clipboard
Move ClientActiveRequests feature to dedicated source files
On Mon, May 18, 2020 at 10:39 PM Alex Rousskov [email protected] wrote:
@rousskov commented on this pull request.
In src/Makefile.am https://github.com/squid-cache/squid/pull/637#discussion_r426907599:
- ClientActiveRequests.h \
- ClientActiveRequests.cc \
Yes, that so called "good" naming convention is not so good for the purpose of listing dependencies in a consistent human-friendly way. We have to pick our poison.
Again, I know that this area is currently very messy, and I do not insist on this minor mess-reducing change.
Yes. It would be out ofd scope for this PR anyway.
-- Francesco
After addressing the latest review concerns, please update PR title and description to reflect the current PR changes.
Must have happened when I upgraded master to a still-supported version of
LTS ubuntu :
Which I will have to do another couple of times to bring to LTS-current.
I'm sorry, I hadn't noticed
-- Francesco
@rousskov , I'm sorry but in all the long history of this PR I have lost track of what is still missing for approval. I apologise for asking you to spend more time on this, but I'm at a loss. The long history means also a lot of rebases which muds the waters.
I think I have resolved all pending issues.
Abandoning. Unentangling from the effects of PR 906 is equivalent to redoing the work