AppleSkin icon indicating copy to clipboard operation
AppleSkin copied to clipboard

[1.10.2] [Bug] Missing Localization for Configuration GUI

Open SnowShock35 opened this issue 8 years ago • 7 comments

Hello Squeek,

Quick bug report for yourself, here's the details. . .

Important Information

  • Minecraft 1.10.2
  • Minecraft Forge 12.18.1.2092
  • AppleSkin 1.0.4

Issue Description

Missing localization for Minecraft Forge configuration GUI.

Steps to Reproduce

  1. Open Minecraft with the above mods/dependencies installed
  2. Click the Mods button on the MainMenu
  3. Search for AppleSkin, Click it in the list and then click the config button

Media

Issue Screenshot #1

SnowShock35 avatar Sep 20 '16 10:09 SnowShock35

P.S. Yes I did write out that issue report just for a minor localization bug. I like consistency with bug reports 😜

SnowShock35 avatar Sep 20 '16 10:09 SnowShock35

@SnowShock35 if you look at the actual config that is how it looks like there too. Pretty sure it is in purpose :)

GirafiStudios avatar Sep 20 '16 15:09 GirafiStudios

But but but. . . 😢

SnowShock35 avatar Sep 20 '16 16:09 SnowShock35

Is there an easy way to localize these strings? I haven't really looked into it; does Forge do a lookup automatically? Or do most mods just make the config option names more proper?

squeek502 avatar Sep 20 '16 17:09 squeek502

Mods just make config option names more proper :) But if you just want them to show up "properly" in the in-game gui config, that is totally doable too!

GirafiStudios avatar Sep 20 '16 17:09 GirafiStudios

If it's easy to add a lang file lookup for the config strings (for displaying in the in-game GUI), then that'd probably be worth doing.

squeek502 avatar Sep 20 '16 17:09 squeek502

Looked a bit into it the other day. Wasen't as easy as I thought it would be :/ Don't actually think it is possible to just localize it for the Forge in-game config.

GirafiStudios avatar Nov 12 '16 21:11 GirafiStudios