generic-device-plugin icon indicating copy to clipboard operation
generic-device-plugin copied to clipboard

Should we version this image?

Open gerhard opened this issue 1 year ago • 3 comments

Hi @squat!

Considering the attention that the plugin is getting in:

  • https://github.com/tailscale/tailscale/issues/10814#issuecomment-2483885981 (see the few comments prior to this one)
  • https://github.com/siderolabs/talos/issues/9322#issuecomment-2425159353 (plus the few comments below)

Would you be open to accepting a PR that versions the resulting image?

While we could pin to a specific git version & sha256 from https://github.com/squat/generic-device-plugin/pkgs/container/generic-device-plugin/versions?filters%5Bversion_type%5D=tagged, I would feel a lot more comfortable picking up an actual tag - CalVer works!


cc @smira @konrad-ohms

gerhard avatar Nov 18 '24 19:11 gerhard

Hi @gerhard, thanks for bringing those discussions to my attention! I'm glad to see some activity. I've always used SHAs for pinning this project, however I'm happy to release a semver v0.1.0 if that works for ppl and would be grateful for a PR to that effect :)

I've been lazy to cut a 1.0.0 because I have a large-ish re-write pending that I want to get in before that.

squat avatar Nov 18 '24 19:11 squat

Hey @squat, any update on this?

buroa avatar Jul 10 '25 17:07 buroa

No blocker here! This just fell off of my to-do list. I should be able to get this cut in the next few days.

squat avatar Jul 10 '25 18:07 squat