Lucas Servén Marín
Lucas Servén Marín
@celian-garcia could you please include tests so that we document our intentions here? Otherwise I'm sure that passing CORS requests will regress without anyone noticing since we are not validating.
@celian-garcia can you elaborate? If the solution is just passing through all OPTIONS requests, why does it matter if the query is in the query parameters or not? Why would...
@celian-garcia now I'm more confused: > Hi @squat sorry, I checked twice and the query string is **actually sent** by the OPTIONS request as well. I thought wrongly that the...
> Query params are passed yes, but not the POST body. That's fine, I think we should still make sure to enforce labels on queries in query parameters IFF they...
Hi @seanbanko can you add a concrete test case? Otherwise I'm sure this will regress
I just re-ran the tests and they are still failing. ping @seanbanko
cc @rycee since you're listed as a maintainer for this module. PTAL if you can
cc @cmacrae @folliehiyuki since you reviewed #5901
PTAL @khaneliman I'm looping in more maintainers since this PR has been waiting for review for a bit now.
@euank that's a good point. Using GPG's suggested/example shell integration effectively breaks the default behavior of `ssh -A`. In order for ssh-agent forwarding to work when setting `SSH_AUTH_SOCK` in this...