whitebox icon indicating copy to clipboard operation
whitebox copied to clipboard

Fix typing in SDK functions

Open stavrostheocharis opened this issue 2 years ago • 2 comments

Description There is a need to change the typing in some functions

Solution

  • dict should be Dict with additional parts inside eg. Dict[str, float]
  • In some parts that None is returned or None is default, Union should be used to include the None value

stavrostheocharis avatar Feb 18 '23 11:02 stavrostheocharis

Related to #139

momegas avatar Feb 22 '23 08:02 momegas

I think some further reading should be done about the return dict types: https://stackoverflow.com/questions/51291722/define-a-jsonable-type-using-mypy-pep-526

sinnec avatar Mar 23 '23 09:03 sinnec