workflow-kotlin

workflow-kotlin copied to clipboard

Using `verifyActionResult` and `testNextRender` sequentially results in confusion on external shared states

1

Discovered this while pairing with @steve-the-edwards: Situation: Using a Mock to verify a number of calls to a dependency of a Workflow `verifyActionResult` will apply the `processedAction` to the current...

weverb2

codelab

1

fkruege

Compose's insets are lost through a backstack container

3

When using a certain configuration of nested workflows (I haven't found exactly the logic there), involving a backstack container (it _might_ be a red herring I guess), Compose's insets are...

Kernald

We calibrated the render pass counting performance tests that run on CI to the speed of the emulators on CI that we use. However, if we re-run locally the outcomes...

steve-the-edwards

renderPassCounterFrameTimeoutComplexNoInitializingStateHighFrequencyEvents Flaky

2

Either that or #840 somehow broke it? Either way, its `@Ignore`ed now so we need to fix it and get it running again.

steve-the-edwards

Compose in the Runtime Take 3

2

To address #665

steve-the-edwards

Wrapper renderings introduce an extra AndroidView unnecessarily when the wrapped rendering's factory is a ComposeScreenViewFactory.

2

I just realized this wrapping pattern (even before this change) might introduce an extra view unnecessarily when the wrapped rendering's factory is a `ComposeViewFactory`. It shouldn't affect correctness but something...

zach-klippenstein

WorkflowRuntime re-write with Compose tree mechanisms?

3

Placeholder for this thought in the `optimization` backlog. @zach-klippenstein and I once talked about re-writing the `WorkflowNode` tree using compose mechanisms (and optimizations?) but the problem there (IIRC) was that...

steve-the-edwards

Do not change Workflow API for COmpose

1

steve-the-edwards

[WIP] Add js target

1

Ready for a pass as the changes are non-trivial. Reviewing by may should help. 1. Add JS target. 2. Fix test names to non back-ticks for common tests can't have...

hujim