retrofit icon indicating copy to clipboard operation
retrofit copied to clipboard

Support using response type keeper with KSP

Open Goooler opened this issue 2 months ago • 8 comments

  • Closes #4176.
  • Based on #4525.

  • [x] CHANGELOG.md's "Unreleased" section has been updated, if applicable.

Goooler avatar Oct 11 '25 10:10 Goooler

Is KSP 2 stable? I'm pretty content being entirely outside the KSP ecosystem, and try to use it in as few places as possible.

I don't want to every be forced to do a Retrofit release because a new version of Kotlin and/or KSP came out.

JakeWharton avatar Oct 14 '25 16:10 JakeWharton

I believe so. I didn't test the processor on KSP1 as I see KSP1 support has been dropped by https://github.com/ZacSweers/kotlin-compile-testing/releases/tag/0.10.0

Goooler avatar Oct 15 '25 01:10 Goooler

Can you take me off all of this github stuff, please?

Thank you.

On Tue, Oct 14, 2025 at 11:13 AM Jake Wharton @.***> wrote:

JakeWharton left a comment (square/retrofit#4526) https://github.com/square/retrofit/pull/4526#issuecomment-3402645464

Is KSP 2 stable? I'm pretty content being entirely outside the KSP ecosystem, and try to use it in as few places as possible.

I don't want to every be forced to do a Retrofit release because a new version of Kotlin and/or KSP came out.

— Reply to this email directly, view it on GitHub https://github.com/square/retrofit/pull/4526#issuecomment-3402645464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOLKW3X4NTW6LEU2FGGZYOD3XUOIXAVCNFSM6AAAAACI5AVDW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBSGY2DKNBWGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

chri1017 avatar Oct 16 '25 02:10 chri1017

No, unsubscribe from your side.

JakeWharton avatar Oct 16 '25 02:10 JakeWharton

https://github.com/google/ksp/releases/tag/2.3.0

Goooler avatar Oct 23 '25 01:10 Goooler

Okay I'm comfortable adding this. We actually use a KSP one internally, not the annotation processing one. I will compare to ensure this meets our needs and then merge.

JakeWharton avatar Oct 24 '25 03:10 JakeWharton

We actually use a KSP one internally, not the annotation processing one. I will compare to ensure this meets our needs and then merge.

This is on my "to do" list for this month. Lots going on, but I haven't forgotten about it.

JakeWharton avatar Nov 06 '25 05:11 JakeWharton

Thanks for the feedback!

Goooler avatar Nov 06 '25 05:11 Goooler