square
Update isHealthy check to be safer
But maybe masks an underlying bug? Those values shouldn't be null at this point.
But maybe masks an underlying bug? Those values shouldn't be null at this point.
Question is: Should isHealthy() return false or throw an exception when these values are null?
At face value, it should return false for this method, however throw an exception elsewhere when these values are non-null.
My reading of the code is that these are preconditions, hence the use of !! in Kotlin whereas in Java we would use something like Objects.requireNotNull(). Because if the preconditions aren't met, something has already failed previously.
Caveat: I'm not an okhttp expert but happened to be looking at a similar exception in okhttp2 earlier today.
Shouldn't be possible after https://github.com/square/okhttp/pull/8514/files, or at least this can't be applied.
That said, it's possible I just moved a logic bug up higher, but this fix isn't the right one anymore.
