leakcanary icon indicating copy to clipboard operation
leakcanary copied to clipboard
verified publisher icon square

shark: make examples compile in different package

Open mhansen opened this issue 1 year ago • 1 comments

Include import statements and fix a few APIs that had drifted, and an invalid variable name.

With this change, you should be able to copy/paste the examples and run them, even if you code is not in the 'shark' package.

I've tested this locally against LeakCanary v2.14 and it compiles now.

It would be nice long-term to have these examples compiling in CI so they stay up to date, but I'm not going to attempt that now.

Towards #2610

mhansen avatar May 08 '24 05:05 mhansen

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 08 '24 05:05 CLAassistant

Thanks. Is any extra work necessary to make this visible on the website? Does it rollout automatically?

On Tue, 21 May 2024 at 09:21, py - Pierre Yves Ricau < @.***> wrote:

Merged #2668 https://github.com/square/leakcanary/pull/2668 into main.

— Reply to this email directly, view it on GitHub https://github.com/square/leakcanary/pull/2668#event-12871995110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZYOMQ4VYRMDCFPZGAEULZDKAQVAVCNFSM6AAAAABHMH3H5OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA3TCOJZGUYTCMA . You are receiving this because you authored the thread.Message ID: @.***>

mhansen avatar May 21 '24 01:05 mhansen