leakcanary icon indicating copy to clipboard operation
leakcanary copied to clipboard

SharkCLI: Read mapping.txt from APK

Open pyricau opened this issue 6 years ago • 4 comments

  • Requires downloading the APK and unzipping it to extract mapping.txt
  • Should be an option, off by default

pyricau avatar Dec 27 '19 15:12 pyricau

Where should the APK be downloaded from? And how do we know there is a mapping file inside it?

mzgreen avatar Dec 28 '19 10:12 mzgreen

The idea is to download the APK using adb pull. This should be off by default, and a flag would turn it on. Then we'd download the APK using adb pull, unzip it, and look for mapping.txt in the assets folder. If missing then the CLI would error out.

pyricau avatar Dec 30 '19 17:12 pyricau

Should this be a separate command that extracts the mapping and saves it on disk or an additional flag that can be used with analyze command?

mzgreen avatar Aug 15 '20 16:08 mzgreen

Probably more like a flag, though I could see both being useful.

pyricau avatar Aug 31 '20 09:08 pyricau