keywhiz icon indicating copy to clipboard operation
keywhiz copied to clipboard

MySQL version in README.md

Open yardenshoham opened this issue 5 years ago • 1 comments

The README.md mentions any version higher than 5.7 is fine:

https://github.com/square/keywhiz/blob/5c5eb3727d224f5e89d41eb448e89777dd0fa30a/README.md#L15

But I don't think that's true as I tried building the Dockerfile with mysql 8 running, specifically 8.0.21, and it failed. I assumed it'd worked because I looked here:

https://github.com/square/keywhiz/blob/5c5eb3727d224f5e89d41eb448e89777dd0fa30a/pom.xml#L49

I think we need to investigate which mysql version is the maximum allowed for keywhiz.

Note: travis uses 5.7.30.

yardenshoham avatar Aug 06 '20 09:08 yardenshoham

Hi,

Also faced same issue yesterday while using Mysql 8.0.12 (Community Edition). Install failed while creating table for groups. groups is reserved word in MySQL from 8.0 onwards

Also MySQL 8 doesn't allow passwords to be empty by default. Need to disable validations to create a new login with empty password.

Worked fine with MariaDB 10.5 - with one exception in Testcase (12 times) - "Failed to SetAutoCommit" Skipped testcases using this flag: mvn install -Dmaven.test.skip=true

Documentation available for first time users is very limited. A Video tutorial with installation, dependencies and usage will definitely help a lot of users

jagadish-pobba avatar Aug 10 '21 06:08 jagadish-pobba