square
Fix Allow multiple audiences
Related Issue
fixed #286
Description
- allow any match for multiple audiences
- currently go-jose requires all match for multiple audiences
@csstaub Could you please review this PR? If the mention is wrong, I'm sorry.
I know that v3 repository already exists. However, I think this is a bug fix, so I raised the PR to this repository.
I can review this, but I don't have permissions on this repository anymore @shnmorimoto so it's not possible for me to do a release with this.
If you raise this on the v3 repo I can merge it there and release it as a minor version
@csstaub Thanks for replying! I understood the current situation.
I raised PR to v3 repository. https://github.com/go-jose/go-jose/pull/10
@mbyczkowski If the mention is wrong, I apologize.
This fix already had been merged on v3 repository. But, it seems v2 version is still being used by many users and libraries. So, if possible, could you merge this fix and release it on this repository?
Bump - I can confirm that we're also running into this issue on our team using v2. Would love to see this merged, especially since v2 is still considered the stable version
The square/go-jose repo is the v2 version, v3 development moved over to go-jose/go-jose
Looks like v3 will solve it but noticed that it is a dependency of github.com/auth0/go-jwt-middleware/v2/jwks so doubtful they will move to the "unstable" v3.
There's a stable release for v3 now so I'd recommend to switch and submit new changes there. I don't have access to this repo anymore since I left Square. I'll see if we can update the README here.