go-jose icon indicating copy to clipboard operation
go-jose copied to clipboard

Support for deferring critical headers to the caller for validation.

Open joesiltberg opened this issue 4 years ago • 4 comments

Here's an attempt to solve #288.

I've used functional options (https://github.com/tmrts/go-patterns/blob/master/idiom/functional-options.md) in order to add options to the Verify*-functions without breaking backwards compatibility.

joesiltberg avatar Apr 27 '20 19:04 joesiltberg

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 27 '20 19:04 CLAassistant

Note that backwards compatibility is still technically broken since the signature is changed, so this shouldn't be back ported to 2.x

joesiltberg avatar Apr 28 '20 06:04 joesiltberg

@mbyczkowski @csstaub should I somehow request a review or mark the pull request as ready for review?

Thanks!

joesiltberg avatar Aug 06 '20 13:08 joesiltberg

Hi @joesiltberg, I'm working on moving dev on the main branch to a new repo in a separate org (will retain v1/2 in this repo, and v3 will be tagged in a new repo that's in a shared org outside of Square). Hang on while I get that set up.

csstaub avatar Aug 06 '20 19:08 csstaub