go-jose icon indicating copy to clipboard operation
go-jose copied to clipboard

Support setting optional JWT headers

Open ekristen opened this issue 9 years ago • 4 comments

See RFC -- https://tools.ietf.org/html/draft-ietf-oauth-json-web-token-32#section-5

While the typ header is optional it is good practice when creating JWT tokens to set typ to JWT (see https://tools.ietf.org/html/draft-ietf-oauth-json-web-token-32#section-3.1)

ekristen avatar Nov 21 '16 22:11 ekristen

I initially didn't implement it as it wasn't required. Will add the necessary tpe header shortly.

On Tue, Nov 22, 2016, 6:23 AM Erik Kristensen [email protected] wrote:

See RFC -- https://tools.ietf.org/html/draft-ietf-oauth-json-web-token-32#section-5

While the typ header is optional it is good practice when creating JWT tokens to set typ to JWT (see https://tools.ietf.org/html/draft-ietf-oauth-json-web-token-32#section-3.1 )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/square/go-jose/issues/126, or mute the thread https://github.com/notifications/unsubscribe-auth/AE_mfTeWeYwt9vLbE8JvBP6AwEd3ta3fks5rAhnTgaJpZM4K4xa0 .

shaxbee avatar Nov 22 '16 04:11 shaxbee

Would be nice to support all the other headers that are acceptable in a JWS which is used by JWT https://tools.ietf.org/html/draft-ietf-jose-json-web-signature-41#page-11

ekristen avatar Nov 29 '16 04:11 ekristen

I should have PR for this by the end of the week.

On Tue, Nov 29, 2016, 12:05 PM Erik Kristensen [email protected] wrote:

Would be nice to support all the other headers that are acceptable in a JWS which is used by JWT https://tools.ietf.org/html/draft-ietf-jose-json-web-signature-41#page-11

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/square/go-jose/issues/126#issuecomment-263470729, or mute the thread https://github.com/notifications/unsubscribe-auth/AE_mfcxbtZp4yqeKxuYJvAmVuV9OBTtZks5rC6SVgaJpZM4K4xa0 .

shaxbee avatar Nov 29 '16 05:11 shaxbee

Ping on this?

mitar avatar Jun 03 '21 14:06 mitar