sqrl-client
sqrl-client copied to clipboard
sqrl-planner
Add dedicated course link (with modal)
Add the ability to share a course as a link, such that when someone opens this link a modal displays information regarding this course. The motivation for this feature is to enable easier coordination with friends, i.e. "take this course with me".
- Potentially add ability to share link containing section(s) selected
How is this any different from just sending the course code to friend? Not sure what benefit this would provide. I like the idea of packaging selected sections into the link. I think that makes it a somewhat worthwhile feature.
I agree, I think inherently sharing selected sections makes this much more valuable.
Possible url spec for implementation could be:
https://app.sqrlplanner.com/course/share?id=<:id>§ions=<:id1>,<:id2>,...
or
https://app.sqrlplanner.com/course/<:id>/share?sections=<:id1>,<:id2>,...
which will open a page including the course information with a button that allows them to add it to their timetable of choice (assuming we are supporting multiple timetables).
The latter looks good to me. I tend to avoid query params if possible—for no reason other than it looks ugly. Also, I'd probably extend that to specify lecture section, tutorial section, and practical section, particularly because I don't believe we have unique ids for sections in case of duplicate section ids, such as CSC110.
I thought the db had unique ids for them? Sure, we can avoid query params, but I'm not sure how you would do it without.
EDIT: Looks like sections are embedded in the course document in the mongodb. I think the cleanest solution is to give sections unique ids. We can keep them as embedded documents but at data syncing time (in the backend) assign uids. Alternatively, we can do what we did with course ids, and do something like <section_type>-<id>.
I meant for the course id. So in this case, we would have
https://app.sqrlplanner.com/course/<:id>/share?lecture=<:lecid>&tutorial=<:tutid>,...