PyMiniRacer icon indicating copy to clipboard operation
PyMiniRacer copied to clipboard

Optional support for i18n

Open adrianschneider94 opened this issue 4 years ago • 1 comments

Steps to reproduce

Install PyMiniRacer via pip.

Expected behavior

I would like to have the possibility to turn on i8n (ECMAScript 402 Spec) when I install PyMiniRacer.

Actual behavior

I8n is turned off by default (in contrast to the normal v8 build). So you have to build everything yourself f you need Intl.

As I build a python wrapper for a lib that deals with schedules, timezone support is crucial. And I think there are many use cases that would require the Intl API. As there are some issues with the Intl.js polyfill, the native API is preferred.

adrianschneider94 avatar Jan 31 '21 13:01 adrianschneider94

Thanks for the suggestion! I tried to compile V8 with i18n turned on but unfortunately I did not find a way to make it optional. Moreover the tests fail on Windows & Alpine Linux.

You can find the wheels here: https://dev.azure.com/sqreenci/PyMiniRacer/_build/results?buildId=4335&view=artifacts&pathAsName=false&type=publishedArtifacts

nizox avatar Mar 04 '21 09:03 nizox