pulseaudio icon indicating copy to clipboard operation
pulseaudio copied to clipboard

Support Module Objects

Open ushis opened this issue 4 years ago • 0 comments

Hi. I'd like work with Module Objects.

Unfortunately your lib does not implement func (cl *Client) Module() like func (cl *Client) Device() or func (cl *Client) Stream(). I would love to find a solution and have 3 proposals:

  1. Implement func (cl *Client) Module(). It's as easy as:
func (pulse *Client) Module(sink dbus.ObjectPath) *Object {
	return NewObject(pulse.conn, DbusInterface+".Module", sink)
}
  1. Expose Client.conn to the user. That way people can use NewObject using the existing dbus connection of the pulse client.
  2. Change the Signature of NewObject to
func NewObject(client *Client, interf string, path dbus.ObjectPath) *Object

Do you have any preference? I would be happy to open a PR.

ushis avatar Feb 11 '21 23:02 ushis