pecl-jsmin icon indicating copy to clipboard operation
pecl-jsmin copied to clipboard

Improve tests for PHP 8

Open andypost opened this issue 2 years ago • 2 comments

based on https://github.com/sqmk/pecl-jsmin/pull/59

  • tests/99-compress-jquery.phpt fails because package from PECL has no jquery shipped, and that's valid as the commited version is outdated
  • tests/missing-argument8.phpt is a copy for PHP 8+ as missing argument is required (throws fatal)

It should also cover current PHP 8.1 beta3 https://github.com/sqmk/pecl-jsmin/issues/58

andypost avatar Aug 28 '21 15:08 andypost

on PHP 8.3 one test started to fail on 32-bit arches

TEST 2/13 [tests/call-multiple-times.phpt]
========DIFF========
     var test=1+1;alert('test');
002- test();
002+ test();F�
========DONE========
FAIL Call jsmin multiple times [tests/call-multiple-times.phpt] 

andypost avatar Sep 17 '23 21:09 andypost

on builders the same test failed for PHP 8.1 and 8.2 on aarch64 and x86_64

andypost avatar Sep 17 '23 22:09 andypost