huejay icon indicating copy to clipboard operation
huejay copied to clipboard

Published 20 hours ago • verified publisher icon sqmk

Add missing Light Model LCT015

Open harleyjester opened this issue 5 years ago • 4 comments

Add missing Light Model LCT015

id: LCT015 manufacturer: Philips name: Hue bulb A19 type: Extended Color Light colorGamut: C

harleyjester avatar Aug 23 '19 19:08 harleyjester

Mind creating a PR with the new class?

sqmk avatar Sep 03 '19 00:09 sqmk

I don't know if a private repository (PR) would solve my problem.

I'm using HueMagic (https://github.com/Foddy/node-red-contrib-huemagic) which use HueJay (https://github.com/sqmk/huejay) and without the correct Model and colorGamut the calculation of the color is not correct.

harleyjester avatar Sep 03 '19 06:09 harleyjester

I’m asking for a pull request (PR) that contains the new model class with the information that is missing. You write / test the new model class locally, and then submit a pull request to the Huejay project with the new class/file you created to be included in this project going forward.

If you are not sure how to do this, I can see about creating the missing model in a near future patch release.

sqmk avatar Sep 04 '19 02:09 sqmk

I have testet it local for a few days and all is fine and works as expected. So i have created a pull request from a fork, because i have no write access, with the new model class file.

harleyjester avatar Sep 05 '19 11:09 harleyjester