huejay icon indicating copy to clipboard operation
huejay copied to clipboard

Add ability to use Philips' remote API

Open codetheweb opened this issue 4 years ago • 1 comments

This PR adds the ability to use the Remote API that Philips provides, as well as a few small bug fixes.

The Remote API is virtually identical to the local bridge API, which made it very easy to add with minimal changes.

In addition, I fixed a few issues:

  • RawGit (the CDN provider that the README logo uses) shut down, so I changed the URL to use jsDelivr
  • I removed package-lock.json from the .gitignore, as NPM recomends that it be committed to version control. (However, after looking at it more the Node.js community seems to be a bit split over whether or not it should be included. I personally think it makes sense but if you want it to be ignored I can revert that change.)

Finally, if you're open to it I'd like to add a linter for the sake of consistent code styling (perhaps in a different PR). I have no personal preference for a specific linter, but I use XO for my projects which has sensible defaults.

This is my first time contributing to this project, so please let me know if I need to rework something or I didn't structure it quite right.

codetheweb avatar Aug 16 '19 22:08 codetheweb

Thanks for the submission.

I'd prefer to go the route of using the strategy pattern and having two classes handling remote and local API calls. Some of your work will be useful for that.

sqmk avatar Sep 03 '19 00:09 sqmk