sqlmap icon indicating copy to clipboard operation
sqlmap copied to clipboard

Published 20 hours ago • verified publisher icon sqlmapproject

Improved crawler logging

Open Murgeye opened this issue 3 years ago • 5 comments

When using --crawl, some logging of Connection and TLS errors lacks information (i.e., the current URL or host and port) to be useful. This pull request improves the logging with this additional information.

Murgeye avatar Sep 15 '22 06:09 Murgeye

...%s" % repr(url) looks bad ...'%s'" % url looks better

stamparm avatar Sep 15 '22 13:09 stamparm

I have updated the PR with the requested changes.

Murgeye avatar Sep 16 '22 09:09 Murgeye

ok. now went through changes. there is lots of noise here AFAICS. lots of redundant information with URLs. i could keep those .debug(...), but everything else seems to me will bring just noise

stamparm avatar Sep 21 '22 20:09 stamparm

ok. now went through changes. there is lots of noise here AFAICS. lots of redundant information with URLs. i could keep those .debug(...), but everything else seems to me will bring just noise

I can see that this adds a lot of noise for non-crawler execution and I could put this into a second debug logging call.

However, that would mean either requiring repeating the information from the current log or (due to multithreading) risking that the error information and the URL/host:port get seperated by other logging calls in between.

Murgeye avatar Oct 21 '22 09:10 Murgeye