querybuilder icon indicating copy to clipboard operation
querybuilder copied to clipboard

Fix for issue #592, json query fix when question mark is used in data

Open kamisoft-fr opened this issue 2 years ago • 3 comments

Fix places where the parameterPlaceholder is hardcoded to a question mark ?

Since the SqlResult still contained ToString method which had the hardcoded placeholder, here is what I've done:

  1. Added compiler to the constructor of SqlResult
  2. Made ParameterPlaceholder public
  3. Added tests PostgresJsonTests

There is so a breaking change on the SqlResult class since its public, So the sqlkata version would be changed as major (2 to 3 or 3 to 4)

kamisoft-fr avatar Nov 03 '22 10:11 kamisoft-fr

Any update on this PR? It would be great if we could have it merged :)

aastovas avatar Mar 24 '23 16:03 aastovas

I highly upvote this

hookenful avatar Apr 21 '23 10:04 hookenful

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Oct 10 '23 15:10 ghost