sqlectron-gui icon indicating copy to clipboard operation
sqlectron-gui copied to clipboard

Lost window when trying to connect to a DB with bad credentials

Open darkwisperer opened this issue 8 years ago • 8 comments

Client: MSSQL APP version: 1.5.0 OS: Win7

While connected to a sql server, if you try to connect to a DB (from the left hand area) that your user does not have access to, you will be dropped out to the main screen and told that it was unable to connect.

Suggested handling of this: Instead of losing the entire window it should gracefully tell the user about the failed login. Maybe flash red or highlight the DB in red or some means of marking that the connect won't work as is.

I was already connected to a DB with several tabs open when I chose to see how sqlectron would handle this edge case.

This issue might affect the other clients. I will try with mysql and report back.

darkwisperer avatar Mar 15 '16 17:03 darkwisperer

Good catch!

I don't have much time to fix it right now. If you could send a pull request I would gladly accept it :smile:

maxcnunes avatar Mar 17 '16 21:03 maxcnunes

If it is still open after I work on the other tickets I have agreed to I will :)

darkwisperer avatar Mar 17 '16 21:03 darkwisperer

have #106 solved this issue?

krolow avatar Apr 14 '16 21:04 krolow

Sounds like it should. I was waiting for a new gui release to confirm this.

darkwisperer avatar Apr 14 '16 21:04 darkwisperer

Sorry @darkwisperer. I was hoping release it earlier. But I have upgraded the build configuration. and I have not got it working properly yet. I hope finish it until this weekend.

maxcnunes avatar Apr 14 '16 23:04 maxcnunes

@maxcnunes no rush :) Just happy to help out when/were I can.

darkwisperer avatar Apr 14 '16 23:04 darkwisperer

Issue still persists in v1.6.2

darkwisperer avatar Apr 20 '16 17:04 darkwisperer

Can confirm still an issue in v1.29.0

darkwisperer avatar Feb 24 '18 00:02 darkwisperer