sqlc icon indicating copy to clipboard operation
sqlc copied to clipboard

Include column types for composite type

Open eaglesemanation opened this issue 8 months ago • 4 comments

With this addition, it should be possible to implement codegen on pgx/v5 side to resolve #2760 . Not sure for other drivers.

I intend to implement codegen as part of this PR as well, just want to get visibility as soon as possible.

eaglesemanation avatar Mar 29 '25 18:03 eaglesemanation

Intentionally left endtoend test failing, until I verify that generated code does work as intended

eaglesemanation avatar Apr 04 '25 06:04 eaglesemanation

Tested this, breaks if a column is an array of composite type. Otherwise works fine, except that pgx.Tx does not implement LoadTypes(...), will look into it soon

eaglesemanation avatar Apr 08 '25 00:04 eaglesemanation

any update?

will it get merged it?

PiotrBaczkowski96 avatar Oct 25 '25 23:10 PiotrBaczkowski96

Doesn't look like anyone had a chance to review this PR, and I haven't reached out to anyone to speed this up. I'm surprised that it still doesn't have any conflicts, so I don't mind making small adjustments to get this merged if needed.

eaglesemanation avatar Oct 26 '25 01:10 eaglesemanation