sqlc icon indicating copy to clipboard operation
sqlc copied to clipboard

Published 20 hours ago • verified publisher icon sqlc-dev

feat: Split models into dedicated package

Open dkhenry opened this issue 2 years ago • 3 comments

This change allows models to be split into a different package. The major benefit of this is to allow multiple sqlc querier packages to use the same scheme, and models. This allows better code modularization and help larger projects keep implementation details independent across logical code modules

dkhenry avatar May 09 '22 23:05 dkhenry

@kyleconroy I am not sure how well this is going to work with the current tests, I have it set up so you can override the package of the model's and give a relative path where they should sit. That is how I am currently using it, but it breaks the tests. Do the tests have a go.mod file and a package I could target ?

dkhenry avatar May 13 '22 22:05 dkhenry

@kyleconroy can you approve the workflows ? I think the tests should be passed

dkhenry avatar May 31 '22 21:05 dkhenry

@kyleconroy any feedback here ? I believe if you approve the workflows it will pass the tests

dkhenry avatar Jun 15 '22 18:06 dkhenry

That sounds great. I will close this PR and get started on a proposal to implement the design

dkhenry avatar Sep 06 '22 14:09 dkhenry