sqlc
sqlc copied to clipboard
sqlc-dev
feat(Go):Add query_parameter_limit conf to codegen
Related to: #1498.
I'm not sure about the approach I took, so just let me know if im solving it wrongly
@kyleconroy sorry, now its passing all the tests, i think... I was not aware of the dev guide (https://github.com/kyleconroy/sqlc/blob/main/docs/guides/development.md)... i was just running make but it wasnt throwing any error
@go-mez Sorry for taking so long to get you a review. I know you've resolved conflicts a few times. I can promise that you'll only need to do it one more time. Thanks again for understanding.
Not sure what's happened, but the tests haven't run for this PR. Maybe another rebase and push will fix things?
@go-mez any chance to get this rebased and pushed? seems like only the docs were waiting... Would be cool to have that feature
@kyleconroy i think it is okay now. could you approve the workflows please ?
@polderudo i'll do it. dont worry!
Thanks man! I didn't want to push however, just asked because we are at the start of a project and that would save a lot of refactoring.
@kyleconroy could you please take a look at the PR and approve the workflows?
@josharian thank you for the review and the suggestion. i will try to address it
Works nice. Thanks for the work, although there is a issue with pgx.
Using sql_package: "pgx/v5"
and building with
sqlc generate --experimental -f sqlc.yaml
will not add the import to
"github.com/jackc/pgx/v5/pgtype"
to the generated files.
@polderudo do you know if this error was happening before? ill try to check it anytime soon.
could you also provide an example in the playground ? (https://play.sqlc.dev/)
It's working, if i remove the new config "query_parameter_limit": 999
Here is a palyground: https://play.sqlc.dev/p/29a65ea348dd6ce7915b9106fc8e2eecb6ea83b53705ae72d9096ac4ac7c56d4