mako icon indicating copy to clipboard operation
mako copied to clipboard

Move some metadata from setup.cfg to pyproject.toml

Open cocolato opened this issue 4 months ago • 8 comments

Ref: https://peps.python.org/pep-0518/#sticking-with-setup-cfg Fix: https://github.com/sqlalchemy/mako/issues/420

Migrating the static matadata to project.toml will also help us to use some modern package managers such as: poetry、uv、pdm.

cocolato avatar Aug 06 '25 15:08 cocolato

Patchset d66d8e444827e49a390737a377622d28e11f1343 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102

sqla-tester avatar Aug 16 '25 15:08 sqla-tester

sorry doing some config cahnges here

zzzeek avatar Aug 16 '25 15:08 zzzeek

Thanks! It has been updated.

cocolato avatar Aug 22 '25 07:08 cocolato

Patchset 1ef7ade42f8b5ece8763cc2c36fa685a9fec2ab6 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102

sqla-tester avatar Aug 22 '25 18:08 sqla-tester

Ref: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#configuring-setuptools-using-pyproject-toml-files. Support for project.license-files and SPDX license expressions in project.license (PEP 639) were introduced in version 77.0.0.

cocolato avatar Aug 25 '25 03:08 cocolato

you can take a look at what's done in alembic or sqlalchemy, that both use pyproject in a fairly similar way:

  • https://github.com/sqlalchemy/sqlalchemy/blob/main/pyproject.toml
  • https://github.com/sqlalchemy/alembic/blob/main/pyproject.toml

it seems that both just require setuptools >=77.0.3 not sure if it may cause issues here with older python version, but I guess we could just drop them

CaselIT avatar Aug 25 '25 19:08 CaselIT

I've removed the wheel dependency during the build process. I can restore it if necessary.

cocolato avatar Aug 27 '25 11:08 cocolato

Patchset c52e72af5f22d01625ac8fa2172249663402ea99 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/6102

sqla-tester avatar Aug 27 '25 11:08 sqla-tester