elasticdl icon indicating copy to clipboard operation
elasticdl copied to clipboard

Published 20 hours ago • verified publisher icon sql-machine-learning

It is redundant to git clone TensorFlow repo.

Open workingloong opened this issue 5 years ago • 2 comments

We only need those proto files to build elasticdl.proto, so we can only download those files by wget. Because TensorFlow repo is huge which makes the image huge.

https://github.com/sql-machine-learning/elasticdl/blob/5fac16d29854001f8f68d4a0d514f4f57b95b8eb/elasticdl/docker/Dockerfile#L57-L60

workingloong avatar Aug 14 '20 03:08 workingloong

You can delete unnecessary files after cloning TensorFlow in the same RUN command. It will both keep the image small and avoid wget network issue.

egolearner avatar Sep 08 '20 08:09 egolearner

You can delete unnecessary files after cloning TensorFlow in the same RUN command. It will both keep the image small and avoid wget network issue.

Good suggestion!

workingloong avatar Sep 08 '20 12:09 workingloong