sql.js icon indicating copy to clipboard operation
sql.js copied to clipboard

Add `useBigInt` option to TypeScript definitions

Open jhurliman opened this issue 4 years ago • 3 comments

The current copy of https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/sql.js/index.d.ts does not have any reference to useBigInt, so I am unable to pass that option in to exec() statements. Whoever is the maintainer of those TypeScript defs, could you please add this new option?

jhurliman avatar Aug 20 '21 22:08 jhurliman

@lovasoa : I wonder if we should pull those defs into this repo instead? I guess one way would be to rewrite the JS in Typescript so they are guaranteed to be correct. I know some forks have taken that approach. Would you be up for reviewing a PR if I were to do that and make the Typescript compilation part of the build process?

Taytay avatar Aug 22 '21 17:08 Taytay

Would you be up for reviewing a PR if I were to do that and make the Typescript compilation part of the build process?

Yes ! I am a little bit busy right now, but I do agree we should switch to typescript.

lovasoa avatar Aug 23 '21 19:08 lovasoa

That would be a great idea, if you need any help with doing some of that I can help in the next few weeks.

rogerfar avatar Dec 01 '21 17:12 rogerfar