sql.js icon indicating copy to clipboard operation
sql.js copied to clipboard

Unable to connect db in IE 11 browser

Open sadashivm opened this issue 6 years ago • 8 comments

Hello, I'm getting console error in IE 11 browser. please find the attached screenshot.

error1 error2

Below console error showing in sql.js file

abort("Assertion failed: this is a legacy browser, build with LEGACY_VM_SUPPORT") at Error: 0 at jsStackTrace (http://127.0.0.1:8081/js/sql.js:3:13747) at stackTrace (http://127.0.0.1:8081/js/sql.js:3:13882) at abort (http://127.0.0.1:8081/js/sql.js:20:8436) at assert (http://127.0.0.1:8081/js/sql.js:3:6512) at Anonymous function (http://127.0.0.1:8081/js/sql.js:3:17850) at Global code (http://127.0.0.1:8081/js/sql.js:2:1) If this abort() is unexpected, build with -s ASSERTIONS=1 which can give more information.

sadashivm avatar May 21 '18 07:05 sadashivm

Hi, I have the same issue when testing my site on IE 11. Is there a workaround, solution available?

mcfly3001 avatar Jun 06 '18 06:06 mcfly3001

Hi, can this also work on IE?

object71 avatar Sep 27 '18 07:09 object71

sad to know it's not feasible on IE.

Thetiso avatar Jul 18 '19 06:07 Thetiso

Would this work with wasm2js?

aaaristo avatar Jul 21 '19 17:07 aaaristo

works adding -s LEGACY_VM_SUPPORT=1 to dist/sql-asm-debug.js

aaaristo avatar Jul 27 '19 20:07 aaaristo

@aaaristo Awesome, I built the sql-asm.js with both -s LEGACY_VM_SUPPORT=1 and -s ALLOW_MEMORY_GROWTH=1 and it works nicely in IE 11 32bit.

diff --git a/Makefile b/Makefile
index 14e0e71..17efa3d 100644
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,8 @@ EMFLAGS = \
 
 EMFLAGS_ASM = \
        -s WASM=0
+       -s LEGACY_VM_SUPPORT=1
+       -s ALLOW_MEMORY_GROWTH=1
 
 EMFLAGS_ASM_MEMORY_GROWTH = \
        -s WASM=0 \

yanli0303 avatar Jun 13 '20 20:06 yanli0303

can we simplify the distribution by merging sql-asm-memory-growth.js into sql-asm.js?

i think the only reason for asm.js these days is legacy-support where performance doesn't matter.

kaizhu256 avatar Jun 13 '20 20:06 kaizhu256

Yes, I agree.

@aaaristo Awesome, I built the sql-asm.js with both -s LEGACY_VM_SUPPORT=1 and -s ALLOW_MEMORY_GROWTH=1 and it works nicely in IE 11 32bit.

diff --git a/Makefile b/Makefile
index 14e0e71..17efa3d 100644
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,8 @@ EMFLAGS = \
 
 EMFLAGS_ASM = \
        -s WASM=0
+       -s LEGACY_VM_SUPPORT=1
+       -s ALLOW_MEMORY_GROWTH=1
 
 EMFLAGS_ASM_MEMORY_GROWTH = \
        -s WASM=0 \

We can merge that and remove asm-memory-growth.

lovasoa avatar Jun 13 '20 22:06 lovasoa