vscode-guides icon indicating copy to clipboard operation
vscode-guides copied to clipboard

`Guides` reports an error if you use HEX-colour fot guides.indent.backgrounds

Open KilianKilmister opened this issue 4 years ago • 1 comments

  • [x] I have search open issues for duplicate issues
  • [x] I have search close issues for potential fixes
  • Guides Version: 0.9.3
  • VSCode Version: 1.44.0
  • OS Version: macOS Catalina v10.15.3

Steps to Reproduce:

  1. add an element to guides.indent.backgrounds in a different format than:
rgba(RRR, GGG, BBB, float:A)`

like any hex-value. eg. #RGBA or #RRGGBBAA

Actual Behaviour:

The settings-editor and -JSON will display an error:

String does not match the pattern of "rgba\s*(\s*\d+\s*,\s*\d+\s*,\s*\d+\s*,\s*(\d(.\d+)?|.\d+)\s*)".

vs-code will display it correctly, tho.

Expected Behaviour:

that the extention should not report an error for using standard vs-code colour notation

KilianKilmister avatar Apr 09 '20 19:04 KilianKilmister

This should be a minor issue since it's not blocking any functionality. It's also simple to fix as well. PR is welcome as I'm pretty much inactive to VSCode in general.

Simply update these RegExp in package.json file on a line that looks something like this https://github.com/spywhere/vscode-guides/blob/6c05f1c64bd1acef5d96acfd987c4299246060da/package.json#L179

spywhere avatar Jun 04 '21 03:06 spywhere