fix inaccurate line numbers

Open vito opened this issue 4 years ago • 2 comments

Hi there!

This is a really cool package. I'm working on a new Lisp and it'd be great to use this package along the way.

I noticed line numbers in error messages seemed way off in a couple experiments, and finally tracked it down to a missing *.

I don't see any tests that cover error locations - happy to write one, just submitting this before I forget to.

Jun 23 '21 19:06 vito

Really happy to hear that you find the package useful. 🙂

Thanks for the PR. Should I merge this or wait for the tests ? ( We definitely need more thorough testing for a lot of things ).

Jun 30 '21 05:06 spy16

@vito Many thanks for the PR. And yes, a test would be most welcome!

Also, please feel free to link us to your Lisp project when you feel it's ready, and we'll be happy to link to it. I've been planning to add a list of "projects using Slurp".

Jun 30 '21 13:06 lthibault